feat: add xpack node multi overview entry#12248
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ssongliu
force-pushed
the
feat/xpack-node-multi-overview
branch
from
bcd9b57 to
22c6bd3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd9b5785c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div class="dropdown-item" @click="openNodeDashboard" v-if="isMasterPro"> | ||
| <SvgIcon class="icon" iconName="p-gailan1" /> | ||
| {{ $t('xpack.node.multiOverview') }} |
There was a problem hiding this comment.
In customized-menu or limited-role setups, the sidebar only exposes routes whose labels are present in hideMenu/showSet (frontend/src/layout/components/Sidebar/index.vue:93-109), but this new shortcut renders for every Pro master because it only checks isMasterPro. Since the router guard only enforces authentication (frontend/src/routers/index.ts) and not menu visibility, users who intentionally do not have NodeDashboard will still see this entry and can navigate straight to /xpack/node/dashboard from the footer dropdown.
Useful? React with 👍 / 👎.
ssongliu
force-pushed
the
feat/xpack-node-multi-overview
branch
from
22c6bd3 to
ace1e4e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Refs #11735