Skip to content

fix: optimize operation log resolve flow and i18n replacements#12123

Merged
wanghe-fit2cloud merged 1 commit intodev-v2from
songliu/oplog-resolve-header-sync
Mar 9, 2026
Merged

fix: optimize operation log resolve flow and i18n replacements#12123
wanghe-fit2cloud merged 1 commit intodev-v2from
songliu/oplog-resolve-header-sync

Conversation

@ssongliu
Copy link
Copy Markdown
Member

@ssongliu ssongliu commented Mar 9, 2026

Refs #11595

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 9, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77c562f264

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ssongliu ssongliu force-pushed the songliu/oplog-resolve-header-sync branch from 77c562f to d3651c4 Compare March 9, 2026 07:09
@f2c-ci-robot f2c-ci-robot bot removed the lgtm label Mar 9, 2026
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 9, 2026

New changes are detected. LGTM label has been removed.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wanghe-fit2cloud. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ProxyType: 'setting.proxyType',
ProxyUrl: 'setting.proxyUrl',
ProxyPort: 'setting.proxyPort',
ProxyPasswdKeep: 'setting.proxyPasswdKeep',

Check failure

Code scanning / SonarCloud

Credentials should not be hard-coded High

Review this potentially hard-coded password. See more on SonarQube Cloud
@wanghe-fit2cloud wanghe-fit2cloud merged commit 740f354 into dev-v2 Mar 9, 2026
3 of 6 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the songliu/oplog-resolve-header-sync branch March 9, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants