Skip to content

fix: ensure local connection is properly closed in CheckLocalConn method#11730

Merged
ssongliu merged 1 commit into1Panel-dev:dev-v2from
HynoR:pr@fssh
Jan 27, 2026
Merged

fix: ensure local connection is properly closed in CheckLocalConn method#11730
ssongliu merged 1 commit into1Panel-dev:dev-v2from
HynoR:pr@fssh

Conversation

@HynoR
Copy link
Copy Markdown
Contributor

@HynoR HynoR commented Jan 27, 2026

What this PR does / why we need it?

#11409

本地稳定复现,不是ws ssh的问题,而是这个不起眼的函数的问题

Summary of your change

修复 checkconnection 检查链接后,不对建立链接做关闭的问题
image
这个函数会创建一个 ssh 链接,返回一个实例

image 这里用_ 忽略了返回,但是依然存在建立的链接,没有调用close方法去关闭 FD,导致 fd 泄露。

@ssongliu

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Jan 27, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ssongliu ssongliu merged commit 930c340 into 1Panel-dev:dev-v2 Jan 27, 2026
0 of 3 checks passed
@HynoR HynoR deleted the pr@fssh branch January 27, 2026 05:41
justadri pushed a commit to justadri/1Panel that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants