Update WP_Mock::expectHookNotAdded() with new params#234
Merged
agibson-godaddy merged 9 commits intotrunkfrom Aug 16, 2023
Merged
Update WP_Mock::expectHookNotAdded() with new params#234agibson-godaddy merged 9 commits intotrunkfrom
WP_Mock::expectHookNotAdded() with new params#234agibson-godaddy merged 9 commits intotrunkfrom
Conversation
unfulvio-godaddy
changed the title
WP_Mock::expectHookNotAdded() with new params
agibson-godaddy
deleted the
233-fix/add-expect-hook-not-added-parameters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds method params to
expectHookNotAddedfor priority and allowed arguments that are symmetrical toexpectHookAdded- and carries them over the aliased functions for filter and action hooks.This way, we can set more specific expectations than assuming hooks will always have
10, 1as priority/args allowed.The PR also improves the WP_Mock hook methods phpdocs and types to match current standards.
Closes: #233
Contributor checklist
Reviewer checklist