Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the selected podcast term doesn't get removed from the podcast block settings. #322

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Ensure that the selected podcast term doesn't get removed from the podcast block settings. #322

merged 5 commits into from
Nov 15, 2024

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Sep 27, 2024 •
edited
Loading

Description of the Change

PR fixes the issues reported in #313 (comment)

  • Display podcast term selection only at the post level now (removed showing twice, post level and block level)
  • Ensure that the selected podcast term doesn't get removed from the podcast block settings

How to test the Change

  1. Create a post.
  2. Add a podcast block.
  3. Choose a podcast term from the post sidebar panel and make sure selected term get reflected in editor block preview.
  4. Save the post and refresh the page. Ensure that selected podcast terms remains unchanged and same podcast term display in frontend.

Changelog Entry

Fixed - Ensure that the selected podcast term doesn't get removed from the podcast block settings.
Removed - The postcast terms selector from the podcast block settings.

Credits

Props @dkotter @iamdharmesh

Checklist:

@github-actions github-actions bot added this to the 1.9.0 milestone Sep 27, 2024
@iamdharmesh iamdharmesh mentioned this pull request Sep 27, 2024
Closed
15 tasks
@jeffpaul
Copy link
Member

@iamdharmesh is there still work pending here or can this open up for review?

@iamdharmesh
Copy link
Member Author

@jeffpaul This is still in WIP. I am mainly blocked on how we want to proceed with the taxonomy settings (point 3 of this comment #313 (comment) and #313 (comment)). Could you please share your thoughts on how we should proceed?

@jeffpaul
Copy link
Member

jeffpaul commented Nov 2, 2024

@iamdharmesh just responded in #313 (comment), sorry for the delay

@iamdharmesh iamdharmesh changed the title [WIP] Ensure that the selected podcast term doesn't get removed from the podcast block settings. Ensure that the selected podcast term doesn't get removed from the podcast block settings. Nov 8, 2024
@iamdharmesh iamdharmesh marked this pull request as ready for review November 8, 2024 18:12
@iamdharmesh iamdharmesh requested a review from a team as a code owner November 8, 2024 18:12
@iamdharmesh iamdharmesh requested review from peterwilsoncc and removed request for a team November 8, 2024 18:12
@iamdharmesh iamdharmesh modified the milestones: 1.9.0, 1.8.1 Nov 8, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 8, 2024
@iamdharmesh iamdharmesh linked an issue Nov 8, 2024 that may be closed by this pull request
Release version 1.9.0 #313
Closed
15 tasks
@iamdharmesh iamdharmesh requested a review from dkotter November 8, 2024 18:13
@dkotter dkotter merged commit acdd7b4 into develop Nov 15, 2024
15 checks passed
@dkotter dkotter deleted the fix/podcast-terms branch November 15, 2024 20:32
@dkotter dkotter modified the milestones: 1.8.1, 1.9.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc peterwilsoncc is a code owner automatically assigned from 10up/open-source-practice

Assignees

@iamdharmesh iamdharmesh

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Release version 1.9.0
3 participants
@iamdharmesh @jeffpaul @dkotter