Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/194: add Gutenberg inspector component to create podcasts #232

Merged
merged 26 commits into from
Jul 17, 2023

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Apr 12, 2023

Description of the Change

Closes #194

This PR adds a Gutenberg inspector component which will allow the editor to create a Podcast from within the editor.

Verification Process

Please watch the video below:

Screen-2023-07-14-123456.mp4

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @jeffpaul @Sidsector9

@jeffpaul
Copy link
Member

jeffpaul commented May 8, 2023

@Sidsector9 is this WIP or can this be moved out of draft and request review?

@jeffpaul jeffpaul added this to the 1.5.0 milestone May 8, 2023
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for a team June 12, 2023 16:17
@Sidsector9 Sidsector9 marked this pull request as ready for review June 21, 2023 10:09
@Sidsector9 Sidsector9 requested a review from a team as a code owner June 21, 2023 10:09
@jeffpaul jeffpaul modified the milestones: 1.5.0, 1.6.0 Jun 28, 2023
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @Sidsector9, Code LGTM!

Note: E2E tests are failing on Minimum and the latest WP env. failing tests dont look related to PR changes.

@Sidsector9 Sidsector9 merged commit 9bbd56a into develop Jul 17, 2023
@Sidsector9 Sidsector9 deleted the feat/194 branch July 17, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve onboarding experience - (phase 2)
3 participants