Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAXONOMY_NAME constant name is going to lead to a conflict. #228

Closed
1 task done
peterwilsoncc opened this issue Apr 4, 2023 · 0 comments · Fixed by #238
Closed
1 task done

TAXONOMY_NAME constant name is going to lead to a conflict. #228

peterwilsoncc opened this issue Apr 4, 2023 · 0 comments · Fixed by #238
Assignees
@jayedul
Labels
type:bug Something isn't working.
Milestone
1.6.0

Comments

@peterwilsoncc
Copy link
Contributor

Describe the bug

In plugin's main file, the constant TAXONOMY_NAME is defined

simple-podcasting/simple-podcasting.php

Lines 20 to 21 in a940466

define( 'PODCASTING_URL', plugin_dir_url( __FILE__ ) );
define( 'TAXONOMY_NAME', 'podcasting_podcasts' );

It's used is several locations throughout the plugin to refer to the podcasting the taxonomy. As such a generic term, it's going to lead to a confict at some point, as suggested by these search results .

I suggest the constant be:

  • deprecated
  • SimplePodcasting\TAXONOMY_NAME or SIMPLE_PODCASTING_TAXONOMY_NAME be used in it's place.

Steps to Reproduce

N/A

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterwilsoncc peterwilsoncc added the type:bug Something isn't working. label Apr 4, 2023
@jayedul jayedul mentioned this issue Jun 13, 2023
Merged
6 tasks
@jayedul jayedul self-assigned this Jun 13, 2023
@jayedul jayedul moved this from Incoming to In Review in Open Source Practice Jun 13, 2023
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jun 13, 2023
@jeffpaul jeffpaul modified the milestones: 1.5.0, 1.6.0 Jun 28, 2023
@jeffpaul jeffpaul moved this from In Review to In Progress in Open Source Practice Jun 28, 2023
@jayedul jayedul moved this from In Progress to In Review in Open Source Practice Jun 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayedul jayedul

Labels
type:bug Something isn't working.
Projects
Open Source Practice
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

TAXONOMY_NAME to PODCASTING_TAXONOMY_NAME 10up/simple-podcasting
3 participants
@peterwilsoncc @jeffpaul @jayedul