Skip to content

Conversation

@jeffpaul
Copy link
Member

Description of the Change

Cherry-picks changes from #239 to trunk to trigger the Readme Updater action and update things over at dotorg.

Closes #236.

How to test the Change

Already tested via #236 (comment).

Changelog Entry

n/a

Credits

n/a

Checklist:

@jeffpaul jeffpaul added this to the 2.8.0 milestone Apr 24, 2025
@jeffpaul jeffpaul self-assigned this Apr 24, 2025
@jeffpaul jeffpaul requested a review from dkotter as a code owner April 24, 2025 20:18
@jeffpaul jeffpaul linked an issue Apr 24, 2025 that may be closed by this pull request
@jeffpaul jeffpaul merged commit a9e2180 into trunk Apr 24, 2025
3 checks passed
@jeffpaul jeffpaul deleted the bump/wp-ver-trunk branch April 24, 2025 20:21
@jeffpaul
Copy link
Member Author

@jeffpaul
Copy link
Member Author

So problem here is probably that the Readme Updater action does this:

Which then does this:
https://github.com/10up/simple-page-ordering/blob/2800b70287ddcf2351d0bea60e40558473572b64/package.json#L26C1-L26C54

So we probably either need to adjust the build command overall to remove makepot or use an adjusted version in this action. @dkotter thoughts?

@dkotter
Copy link
Collaborator

dkotter commented Apr 25, 2025

So we probably either need to adjust the build command overall to remove makepot or use an adjusted version in this action. @dkotter thoughts?

This is almost certainly the issue. I think what I'd suggest is removing npm run makepot from the build command and anywhere we need language files built (I think just in the final deploy workflow) we can adjust that to run npm run makepot after running npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress

2 participants