You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So we probably either need to adjust the build command overall to remove makepot or use an adjusted version in this action. @dkotter thoughts?
This is almost certainly the issue. I think what I'd suggest is removing npm run makepot from the build command and anywhere we need language files built (I think just in the final deploy workflow) we can adjust that to run npm run makepot after running npm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Cherry-picks changes from #239 to
trunkto trigger the Readme Updater action and update things over at dotorg.Closes #236.
How to test the Change
Already tested via #236 (comment).
Changelog Entry
n/a
Credits
n/a
Checklist: