Undefined array key error when viewing pages in admin panel#219
Merged
peterwilsoncc merged 2 commits into10up:developfrom Aug 15, 2024
xDehy:develop
Merged
Undefined array key error when viewing pages in admin panel#219peterwilsoncc merged 2 commits into10up:developfrom xDehy:develop
peterwilsoncc merged 2 commits into10up:developfrom
xDehy:develop
Conversation
Contributor
Author
|
Just cleaned it up a little, realised I added extra, unnecessary lines of code |
jeffpaul
requested review from
peterwilsoncc
and removed request for
dkotter and
jeffpaul
peterwilsoncc
approved these changes
Aug 15, 2024
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks @xDehy, this looks good to me.
I was able to reproduce the issue on an Admin > Pages list page containing only one page. This PR fixes the issue.
Contributor
Does the person who found the issue have a GitHub account so we can give them credit for discovery? |
Contributor
Author
Nope, unfortunately not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request addresses an "Undefined array key" error that occurs when a post parent ID does not exist in the
$children_pagesarray.Changes Made:
isset()check before accessing the$children_pagesarray with the post parent ID.$siblingsis set to an empty array to handle the case gracefully.Closes #218
How to test the Change
Due to me not knowing exactly how this bug happened as it wasnt originally found by me, I can only assume. This bug was originally found by someone who edited a picture on a page and then dragged that page around to be a child page of another, which resulted in the Undefined array key error on the pages panel.
Changelog Entry
Credits
Props @xDehy
Checklist: