Skip to content

Bump WordPress "tested up to" version 6.4 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sidsector9 merged 1 commit into from
Nov 8, 2023
Merged

Bump WordPress "tested up to" version 6.4 #177

Sidsector9 merged 1 commit into from
Nov 8, 2023

Conversation

@jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Nov 3, 2023

Description of the Change

Bumps WordPress "tested up to" version 6.4

Closes #171.

How to test the Change

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.4.

Credits

Props @qasumitbagthariya @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.6.1 milestone Nov 3, 2023
@jeffpaul jeffpaul self-assigned this Nov 3, 2023
@jeffpaul jeffpaul requested a review from a team as a code owner November 3, 2023 22:04
@jeffpaul jeffpaul requested review from faisal-alvi and removed request for a team November 3, 2023 22:04
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 3, 2023
@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 3, 2023

@qasumitbagthariya I'm seeing failures on trunk when bumping to WP 6.4. Are you certain your tests passed?

@qasumitbagthariya
Copy link

qasumitbagthariya commented Nov 6, 2023

@jeffpaul
It works for 2.6.0 but does not work with the trunk branch.

faisal-alvi
faisal-alvi approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran the tests and they passed this time.

Approving, not tested the plugin thoroughly.

@qasumitbagthariya can you please test again and then it'll be good to merge?

@qasumitbagthariya
Copy link

qasumitbagthariya commented Nov 6, 2023 •
edited
Loading

@faisal-alvi

The functionality works when downloading the plugin from https://wordpress.org/plugins/simple-page-ordering/ but looks like an issue when we download from the git release zip and trunk branch.

Can you please check from your end?

The issue is not a blocker for this PR so I'm approving this PR. ✅

cc @jeffpaul

@faisal-alvi
Copy link
Contributor

faisal-alvi commented Nov 7, 2023

The issue is not a blocker for this PR so I'm approving this PR.

@qasumitbagthariya since the issue doesn't seem to be related to WordPress 6.4, could you please open a separate issue ticket for it? Once that's done, we can merge this PR.

@qasumitbagthariya
Copy link

qasumitbagthariya commented Nov 7, 2023

@faisal-alvi

Already the Issue has been created #178

@Sidsector9 Sidsector9 merged commit 270aaac into develop Nov 8, 2023
@Sidsector9 Sidsector9 deleted the bump/wp-version branch November 8, 2023 13:09
@Sidsector9 Sidsector9 modified the milestones: 2.6.1, 2.6.2 Nov 8, 2023
@jeffpaul jeffpaul modified the milestones: 2.6.2, 2.6.1 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

@qasumitbagthariya qasumitbagthariya qasumitbagthariya approved these changes

Assignees

@jeffpaul jeffpaul

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

2.6.1

Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with an upcoming version of WordPress

4 participants

@jeffpaul @qasumitbagthariya @faisal-alvi @Sidsector9