upkeep/163: Fix fatal error on PHP 5.6#166
Conversation
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
@Sidsector9 Thank you for the PR.
PR adds composer dependency to the plugin but it seems we have ignored the vendor folder in .distignore file. It may result in vendor folder missing in the release zip. Could you please help to check it once?
Also, we have to add steps for composer package installation in our GH action workflows. especially in deploy workflow. Could you please help with it?
Thank you.
Sidsector9
force-pushed
the
upkeep/163
branch
2 times, most recently
from
eafce4f to
f5d13d4
Compare
simple-page-ordering.php
Outdated
There was a problem hiding this comment.
In the event further composer dependencies are added at a later date includingthis here may cause problems if the new dependencies require > PHP 5.6
Would it be possible to do one of the following:
- only require the compatibility checker in the vendor path
- install the compatibility checker outside of
vendorand require it from the custom location
There was a problem hiding this comment.
@peterwilsoncc I've taken the approach to move the library from vendor to 10up-lib directory and also loaded the SPO main class after the validation is completed.
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for the PR @Sidsector9. Code LGTM! and it tests well (Didn't throw any fatal error on 5.6 now).
In release build zip I have noticed some .md files in 10up-lib folder but it doesn't seems a blocker here. So, we are good to go here.
Thank you.
|
Thanks for testing @iamdharmesh |
3 participants
Description of the Change
This PR does the following:
Simple_Page_Orderingto a separate file.class-simple-page-ordering.phponly when platform validation passes.Closes #163
How to test the Change
Please follow steps from the issue.
Changelog Entry
Credits
Props @peterwilsoncc @Sidsector9
Checklist: