Skip to content

Conversation

@ruscoe
Copy link
Contributor

@ruscoe ruscoe commented Mar 11, 2023

Description of the Change

Corrects a typo by replacing 'successs' with 'success'.

Closes #132

How to test the Change

  1. Check line 559 of simple-page-ordering.php
  2. Ensure 'success' has just two instances of 's' (two esses?)

Changelog Entry

Removed extra s from success.

Credits

Props @ruscoe

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@ruscoe ruscoe requested a review from a team as a code owner March 11, 2023 01:12
@ruscoe ruscoe requested review from Sidsector9 and removed request for a team March 11, 2023 01:12
Copy link
Contributor

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @ruscoe

Approving as the failing tests are not due to changes in this PR.

@Sidsector9 Sidsector9 merged commit 1830d92 into 10up:develop Mar 13, 2023
@jeffpaul jeffpaul added this to the 2.5.0 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There's an extra 's' in 'success' when creating an instance of WP_REST_Response

3 participants