Allow uploads on all pages using Media JS APIs#279
Merged
Conversation
1 task
4 tasks
dkotter
approved these changes
Sep 17, 2025
Collaborator
dkotter
left a comment
dkotter
left a comment
There was a problem hiding this comment.
Tested a few different upload scenarios and all are working for me now so I think this is good to go. If we get reports of other areas that still aren't working, we can look into those
github-project-automation
bot
moved this from Code Review
to QA Testing
in Open Source Practice
github-project-automation
bot
moved this from QA Testing
to Done
in Open Source Practice
|
@darylldoyle @dkotter I'm seeing a new error in the Customizer with an upload field there which we did not have issues with before: Screen.Recording.2025-12-04.at.11.24.01.mov |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request introduces an additional hook to ensure SVG uploads are allowed in all relevant media upload contexts. The main change is the use of the
media_upload_tabsaction to call theallow_svg_from_uploadmethod, ensuring SVG support is consistently applied across all upload interfaces.Closes #240, #244
How to test the Change
Changelog Entry
Credits
Props @darylldoyle
Checklist: