Bump svg sanitization library #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs:feedback
|
@darylldoyle thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
darylldoyle
force-pushed
the
update/svg-lib-0.22.0
branch
from
70fdb91 to
4972491
Compare
github-actions
bot
added
needs:code-review
dkotter
approved these changes
Aug 12, 2025
Collaborator
dkotter
left a comment
dkotter
left a comment
There was a problem hiding this comment.
Tested with an svg that had an anchor tag with the attribute xlink:hReF. Before this PR, that attribute was not being sanitized. After pulling this PR and running composer install, the attribute does get sanitized properly
github-project-automation
bot
moved this from Code Review
to QA Testing
in Open Source Practice
github-project-automation
bot
moved this from QA Testing
to Done
in Open Source Practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updated the
enshrined/svg-sanitizepackage from version^0.21.0to^0.22.0incomposer.jsonto use the latest release.This updated resolves an issue where attribute name case inconsistencies (e.g.,
xlink:Hrefinstead ofxlink:href) in XML processing could cause namespace lookups and sanitisation to fail. Attribute names in both namespaced and non-namespaced contexts are now normalised to their expected lowercase form before processing. This ensures consistent sanitisation ofxlink:hrefand other targeted attributes regardless of their original case.Changelog Entry
Credits
@darylldoyle
Checklist: