Fix #210 | PHP 8.3 compatibility #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksaju
changed the title
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
a team,
darylldoyle,
dkotter and
jeffpaul
faisal-alvi
requested changes
Aug 14, 2024
Contributor
faisal-alvi
left a comment
faisal-alvi
left a comment
There was a problem hiding this comment.
Thank you for the PR @sksaju. Could you please address the PHP compatibility and PHPCS pipeline issues?
Contributor
|
PHP 7.4 Compatibility has been resolved. |
faisal-alvi
approved these changes
Sep 2, 2024
Contributor
faisal-alvi
left a comment
faisal-alvi
left a comment
There was a problem hiding this comment.
Confirmed that the get_magic_quotes_gpc function is not used in the library after version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updated the
enshrined/svg-sanitizepackage to 0.19.0 to fix the PHP 8.3 compatibility issue.Closes #210
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: