Prevent LockedStream console error by providing metaData in advance #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing the metadata should prevent the locked stream error. Additional formatting fixes were also applied.
1 task
|
One caveat to note here is that this behavior is only applied to the frontend of the site. It might be worth applying this same consideration to the editor interface, but it feels like a lower value-to-time ratio for that lift. If we were to do it in the editor we'd just need to be able to get the attachment metadata via a JS method and then just do the same thing I'm doing in the frontend.js file when WebAmp is initialized. |
|
@cadic resolving the merge conflict here and then merging this would be helpful, thanks! |
|
@Sidsector9 this needs another review after conflicts resolved (just package-lock.json) |
Sidsector9
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change resolves a reported error that occurs due to the metaData key being missing from the initialTracks provided to Webamp.
You can reproduce this error on the official CodeSandbox demo by just removing the metaData key: https://codesandbox.io/s/y0xypox60z.
Closes #46
How to test the Change
Changelog Entry
Credits
Props @iansvo @ajmaurya99
Checklist: