feat/45: add milkdrop visualizations #67
Conversation
Sidsector9
requested review from
a team and
iamdharmesh
and removed request for
a team
There was a problem hiding this comment.
Thanks for the PR @Sidsector9, Code looks good to me and it works fine as well, could you please help to fix the reported eslint errors before we proceed on merging this?
There was a problem hiding this comment.
Thanks for the changes @Sidsector9, as we discussed internally on slack I added milkdrop support to the admin player previewer. please help to take a look once whenever you get a chance.
Thanks
|
@iamdharmesh @jeffpaul Looks like the WPCS linter is failing here because it isn't able to detect the value for prefixes. I have tried updating the file I don't have the repo permissions to modify the workflow, but if someone who does have access can test this we should be able to get it sorted. Ultimately we need to set the value of Is this something one of you can test for me? I can continue my evaluation of other behavior but I believe we'll need that resolved in order to move this forward anyway, right? |
Fixed issue that caused the .playlist-menu .bar element to overflow it’s container in the editor.
|
I added some CSS to fix an editor-style bug when using the block preview. But otherwise, everything seems to function well and work as expected. |
|
Wondering if we could add some additional flags to that WPCS action to handle that? https://github.com/10up/wpcs-action#usage |
|
Thanks for phpcs config changes and checking on this @iansvo, it seems we had an issue in 10up/wpcs-action and PR 10up/wpcs-action#20 has resolved it. So, we can ignore this for now as the workflow will be fixed once the new version is released for action. Thanks. |
Description of the Change
This PR adds support for Milkdrop visualisations.
Closes #45
Screenshot
Desktop:
desktop.mp4
Mobile:
Changelog Entry
Credits
Props @jeffpaul @gsarig @Sidsector9
Checklist: