Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep/57: bump min WP and PHP versions #66

Merged
merged 5 commits into from
Nov 9, 2022
Merged

upkeep/57: bump min WP and PHP versions #66

merged 5 commits into from
Nov 9, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 30, 2022 •
edited
Loading

Description of the Change

Closes #57

Changelog Entry

Changed - Bump minimum PHP version from 5.6 to 7.4
Changed - Bump minimum node version from 12 to 16
Changed - Bump minimum composer version to 2

Credits

Props @vikrampm1 @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested review from a team and cadic and removed request for a team October 30, 2022 09:59
@Sidsector9 Sidsector9 self-assigned this Oct 30, 2022
cadic
cadic suggested changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, maybe use .nvmrc in existing workflow?

.nvmrc
@@ -0,0 +1 @@
v16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eslint.yml workflow is using hardcoded Node version, should we refer to this .nvmrc file instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadic this is done!

@Sidsector9 Sidsector9 requested a review from cadic November 1, 2022 07:47
cadic
cadic approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I see WPCS action failure, not related to the current change

@jeffpaul jeffpaul merged commit ce13952 into develop Nov 9, 2022
@jeffpaul jeffpaul deleted the upkeep/57 branch November 9, 2022 23:56
@jeffpaul jeffpaul added this to the 1.1.1 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadic cadic cadic approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Bump WordPress and PHP minimums
3 participants
@Sidsector9 @cadic @jeffpaul