upkeep/40: PHP8 compat workflow #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
previously approved these changes
Apr 1, 2022
There was a problem hiding this comment.
@Sidsector9 LGTM - just requires a version bump before the merge. Approving now, as the change is minor.
Sidsector9
changed the title
faisal-alvi
approved these changes
Apr 4, 2022
3 tasks
jeffpaul
reviewed
Jun 14, 2022
| @@ -4,7 +4,7 @@ | |||
| * Plugin URI: https://wordpress.org/plugins/retro-winamp-block/ | |||
| * Description: A Winamp-styled audio block for all your retro music player needs. | |||
| * Version: 1.0.1 | |||
| * Requires at least: 5.2 | |||
| * Requires at least: 5.8 | |||
| * Requires PHP: 7.2 | |||
There was a problem hiding this comment.
Should this get changed to 5.6?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Checklist:
Changelog Entry
upkeep: Added PHP8 compatibility workflow
Credits
Props @Sidsector9