Fix/block directory #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
requested changes
Nov 19, 2021
There was a problem hiding this comment.
@jeffpaul in this case the block directory check is actually incorrect.
The apiVersion value needs to be an integer as defined here in the Schema:
https://github.com/WordPress/gutenberg/blob/d718cb0ae5571e9c6199a7eaacf8f063804f7d52/schemas/json/block.json#L18-L23
The script value can either be a path to a js file or the name of a js handle when the script is registered via wp_register_script
fabiankaegy
reviewed
Nov 19, 2021
block.json
Outdated
| "editorScript": "file:./build/index.js", | ||
| "editorStyle": "file:./build/index.css", | ||
| "script": "winamp-block-frontend", | ||
| "script": "winamp-block-frontend.js", |
There was a problem hiding this comment.
this will not work as the winamp-block-frontend string refers to the handle the script was registered under.
fabiankaegy
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In running the plugin thru the Block Plugin Checker, there were some issues flagged:
This PR updates to the expected block.json metadata and also updates some stray GitHub repo links to the correct name.
Alternate Designs
n/a
Benefits
Ensures the plugin can appear in the Block Directory
Possible Drawbacks
none identified
Verification Process
Run the plugin thru the Block Checker and see that issues are resolved
Checklist:
Applicable Issues
n/a
Changelog Entry