Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page loading at the bottom #38

Closed
1 task done
npy88 opened this issue Mar 7, 2022 · 7 comments · Fixed by #56
Closed
1 task done

page loading at the bottom #38

npy88 opened this issue Mar 7, 2022 · 7 comments · Fixed by #56
Assignees
Labels
type:question Further information is requested.
Milestone

Comments

@npy88
Copy link

npy88 commented Mar 7, 2022

Describe your question

hi thanks so much for this plugin! I'm coming across an issue of my page loading at the bottom (where the player is located) but I need the page to load at the top. Do you know what I could do to fix this?

Code of Conduct

  • I agree to follow this project's Code of Conduct
@npy88 npy88 added the type:question Further information is requested. label Mar 7, 2022
@vikrampm1 vikrampm1 moved this to Incoming in Open Source Practice Mar 8, 2022
@jeffpaul
Copy link
Member

jeffpaul commented Mar 8, 2022

@npy88 can you share an example of this? Possibly check to see if there are any console errors? Would also help to confirm your WP version, theme version, Winamp plugin version, and any other active plugin versions in case there's a compatibility issue we need to take into concern.

@jeffpaul jeffpaul added the needs:feedback This requires reporter feedback to better understand the request. label Mar 8, 2022
@jeffpaul jeffpaul self-assigned this Mar 8, 2022
@npy88
Copy link
Author

npy88 commented Mar 8, 2022

should be viewable here https://www.wifinails.com/test-home/
I have the latest Wordpress version, Winamp version 1.0.1, and the following active plugins:
Elementor 3.5.6
Elementor pro 3.6.3
essential add ons for elementor 5.0.10
image hover effects elementor Addon 1.3.5
insert headers and footers 1.6.0
jetpack 10.7
payment plugins for stripe WooCommerce 3.3.16
shopengine 2.1.0
ultimate add ons for Gutenberg 1.25.4
updraftplus 1.22.8
w3 total cache 2.2.1
WooCommerce 6.2.1
woo commerce paypal payments 1.7.0
wp content copy protection 3.4.5

thank you!

@jeffpaul jeffpaul removed their assignment Mar 10, 2022
@jeffpaul jeffpaul removed the needs:feedback This requires reporter feedback to better understand the request. label Mar 10, 2022
@iansvo iansvo self-assigned this May 9, 2022
@iansvo
Copy link
Contributor

iansvo commented May 9, 2022

@npy88 Thanks for the additional details on this. I was looking into the issue and I think I have a patch that may do the trick. To be sure, I was hoping you could test this out on your site so we can determine if this fix will be appropriate. In my local testing, it does appear to resolve the issue though.

Branch link: https://github.com/10up/retro-winamp-block/tree/fix/issue-38-page-jump-on-load

retro-winamp-block.zip

Please install this version of the plugin then let me know if you're still experiencing the issue. This shouldn't cause any data loss or cause your block to need to be set up again.

If you have any other questions just reply back here.

@jeffpaul jeffpaul moved this from Incoming to In Progress in Open Source Practice May 10, 2022
@jeffpaul jeffpaul added this to the Future Release milestone May 10, 2022
@Sidsector9 Sidsector9 modified the milestones: Future Release, 1.2.0 Jun 21, 2022
@jeffpaul
Copy link
Member

@npy88 any updates from testing @iansvo's branch and whether that resolves your issue?

@jeffpaul
Copy link
Member

@iansvo might as well be worth opening as a PR for us to get through code review in case this does resolve things for @npy88.

@npy88
Copy link
Author

npy88 commented Jun 29, 2022 via email

@iansvo
Copy link
Contributor

iansvo commented Jul 11, 2022

PR has been added: #56

@jeffpaul jeffpaul moved this from In Progress to In Review in Open Source Practice Jul 11, 2022
@jeffpaul jeffpaul modified the milestones: 1.2.0, 1.1.1 Jul 19, 2022
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jan 23, 2023
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants