Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block crashes after selecting audio file(s) #30

Closed
helen opened this issue Nov 19, 2021 · 1 comment · Fixed by #31
Closed

Block crashes after selecting audio file(s) #30

helen opened this issue Nov 19, 2021 · 1 comment · Fixed by #31
Assignees
@fabiankaegy
Labels
type:bug Something isn’t working.
Milestone
1.0.1

Comments

@helen
Copy link
Collaborator

helen commented Nov 19, 2021

Describe the bug
After inserting the block and picking one or more audio files, I get the dreaded "this block has encountered an error" message and TypeError: l.__experimentalUseInnerBlocksProps is not a function in my console. I have a feeling this is related to my particular install, specifically that I am on WP nightly and perhaps because I have Gutenberg active.

Steps to Reproduce

  1. Insert Winamp block
  2. Choose one or more items from the media library
  3. See errors

Expected behavior
A working block :)

Screenshots

Environment information

  • Device: Mac Mini
  • OS: MacOS 11.6
  • Browser and version: Firefox 95.0b4
  • WordPress version: Nightly (currently 5.9-alpha-52211)
  • Plugins and version: Gutenberg 11.9.1
  • Theme and version: Tove (FSE)
  • Site Health Info:

Additional context
@helen helen added the type:bug Something isn’t working. label Nov 19, 2021
@fabiankaegy
Copy link
Member

Yes that is exactly it. 11.9 & 5.9 have stabilized the API for useInnerBlocksProps

@fabiankaegy fabiankaegy mentioned this issue Nov 19, 2021
Merged
@fabiankaegy fabiankaegy linked a pull request Nov 19, 2021 that will close this issue
fix useInnerBlocksProps import to work with 5.9 #31
Merged
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Nov 23, 2021
@jeffpaul jeffpaul moved this from Incoming to Merged in Open Source Practice Nov 23, 2021
@jeffpaul jeffpaul added this to the 1.1.0 milestone Nov 23, 2021
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.1 Dec 9, 2021
@jeffpaul jeffpaul moved this from Merged to Done/Released in Open Source Practice Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiankaegy fabiankaegy

Labels
type:bug Something isn’t working.
Projects
Open Source Practice
Archived in project
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

fix useInnerBlocksProps import to work with 5.9 10up/retro-winamp-block
3 participants
@helen @jeffpaul @fabiankaegy