Run the fields population method on init instead of when the class instance is generated #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance is generated
dkotter
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The problem here is that the plugin was attempting to localize some strings very early, the moment the class instance was generated. Since this was too early, the call of the method was moved to a callback of the
initaction.Closes #339
How to test the Change
The notice was thrown on any request, provided that the plugin was active. Browsing the site and not seeing the warning in the logs, while the plugin's setting remain usable, should be the best way to test that the issue is resolved.
Changelog Entry
Credits
Props @kmgalanakis
Checklist: