feat/153: introduce append_ips() method to be used in favour of add_ips() #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
@Sidsector9 Thank you for the PR.
- ✅ Test the function Restricted_Site_Access::append_ips() as per the inline documentation and verify if the IPs are added.
- ✅ Verify if 2 IPs can share the same label.
Sidsector9
dismissed
faisal-alvi’s stale review
The merge-base changed after approval.
faisal-alvi
previously approved these changes
Aug 8, 2023
Sidsector9
dismissed
faisal-alvi’s stale review
The merge-base changed after approval.
|
@faisal-alvi @Sidsector9 it seems like this should be otherwise good to merge in, correct? |
|
@jeffpaul yes, the PR review was dismissed due to a bug - https://github.com/orgs/community/discussions/58535 |
|
@jeffpaul as far as this is because of Github's own issue, I think we can merge it. |
faisal-alvi
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #153
How to test the Change
Restricted_Site_Access::append_ips()as per the inline documentation and verify if the IPs are added.Changelog Entry
Credits
Props @Sidsector9
Checklist: