Added support for custom marker icon. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
a team and
Sidsector9
and removed request for
a team
|
@fabiankaegy could use your review on this as it was one of the items you flagged as a nice-to-have addition here. |
fabiankaegy
reviewed
Nov 15, 2022
There was a problem hiding this comment.
This is looking great 🎉 Thank you for working on it @iamdharmesh :)
I left two comments. One is just a suggestion and the other that I believe needs to be handled before we can land this.
Let me know if you have any questions :)
fabiankaegy
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As requested in #92, this PR adds support for the custom marker icon. Users can upload an icon image from the marker settings, Please check the following screenshot for more information.
Closes #92
How to test the Change
Changelog Entry
Credits
Props @iamdharmesh @dinhtungdu @fabiankaegy
Checklist: