-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linting actions to support GH Actions summary #128
Conversation
d18d973
to
e5c9b0d
Compare
Leave this PR as a draft until 10up/wpcs-action#12 is merged. |
@dinhtungdu that WPCS item is merged, good to open this PR up for review now? |
@jeffpaul I will mark this ready for review after releasing version 1.3.4 for WPCS because I want to keep using the |
@fabiankaegy This is ready for review. Can you please take a look? |
@fabiankaegy looking for your review/feedback here, please and thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this :)
@dinhtungdu probably worth documenting this in /actions-wordpress/, /wpcs-action/, and/or /open-source-best-practices/ so others can copy/paste and benefit from this great work! |
I create 10up/actions-wordpress#38 per your suggestion. Thank you so much! |
Description of the Change
This PR updates our linting workflows to support new GH Actions summary feature:
lint:js
script to generate the JSON report forataylorme/eslint-annotate-action
and https://github.com/10up/eslint-json-to-md.EXTRA_ARGS
flag introduced in Add new flag:EXTRA_ARGS
to support custom arguments wpcs-action#12 to generate a JSON report for https://github.com/10up/phpcs-json-to-md.Verification Process
The failed workflow: https://github.com/10up/maps-block-apple/actions/runs/2331451639
Checklist:
Changelog Entry
Credits
Props @dinhtungdu