Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting actions to support GH Actions summary #128

Merged
merged 17 commits into from
Jun 29, 2022

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented May 15, 2022

Description of the Change

This PR updates our linting workflows to support new GH Actions summary feature:

Verification Process

The failed workflow: https://github.com/10up/maps-block-apple/actions/runs/2331451639

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @dinhtungdu

@dinhtungdu dinhtungdu force-pushed the test/wpcs-gh-actions-summary branch from d18d973 to e5c9b0d Compare May 16, 2022 08:39
@dinhtungdu dinhtungdu changed the title Try: GH Actions summary Update linting action to support GH Actions summary May 16, 2022
@dinhtungdu dinhtungdu changed the title Update linting action to support GH Actions summary Update linting actions to support GH Actions summary May 16, 2022
@dinhtungdu dinhtungdu requested a review from fabiankaegy May 17, 2022 02:03
@dinhtungdu
Copy link
Contributor Author

Leave this PR as a draft until 10up/wpcs-action#12 is merged.

@jeffpaul
Copy link
Member

@dinhtungdu that WPCS item is merged, good to open this PR up for review now?

@jeffpaul jeffpaul added this to the 1.0.3 milestone Jun 13, 2022
@dinhtungdu
Copy link
Contributor Author

@jeffpaul I will mark this ready for review after releasing version 1.3.4 for WPCS because I want to keep using the stable branch.

@dinhtungdu dinhtungdu marked this pull request as ready for review June 15, 2022 01:37
@dinhtungdu
Copy link
Contributor Author

@fabiankaegy This is ready for review. Can you please take a look?

@dkotter dkotter modified the milestones: 1.0.3, 1.1.0 Jun 27, 2022
@jeffpaul
Copy link
Member

@fabiankaegy looking for your review/feedback here, please and thanks!

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this :)

@dinhtungdu dinhtungdu merged commit 32933f0 into develop Jun 29, 2022
@dinhtungdu dinhtungdu deleted the test/wpcs-gh-actions-summary branch June 29, 2022 10:23
@jeffpaul
Copy link
Member

@dinhtungdu probably worth documenting this in /actions-wordpress/, /wpcs-action/, and/or /open-source-best-practices/ so others can copy/paste and benefit from this great work!

@dinhtungdu
Copy link
Contributor Author

@dinhtungdu probably worth documenting this in /actions-wordpress/, /wpcs-action/, and/or /open-source-best-practices/ so others can copy/paste and benefit from this great work!

I create 10up/actions-wordpress#38 per your suggestion. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants