Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom marker icon #92

Closed
dinhtungdu opened this issue Jun 18, 2021 · 1 comment · Fixed by #136
Closed

Support custom marker icon #92

dinhtungdu opened this issue Jun 18, 2021 · 1 comment · Fixed by #136
Assignees
@iamdharmesh
Labels
help wanted Extra attention is needed
Milestone
1.1.0

Comments

@dinhtungdu
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

MapKit support custom glyph image for marker annotation, our block should support that feature as well.

Original wp.org report: https://wordpress.org/support/topic/how-change-marker-icon/
@jeffpaul jeffpaul added this to the Future Release milestone Jun 22, 2021
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jun 22, 2021
@fabiankaegy
Copy link
Member

For context this is the documentation from Apple about the custom glyph support: https://developer.apple.com/documentation/mapkitjs/mapkit/markerannotation

const portland = new mapkit.Coordinate(45.5231, -122.6765);
const customMarker = new MarkerAnnotation(portland, {
    color: "green",
    glyphColor: "brown",
    glyphImage: { 1: "glyphImage.png" },
    selectedGlyphImage: { 1: "detailedIcon.png", 2: "detailedIcon_2x.png", 3: "detailedIcon_3x.png" }
});

And this is where we define the markers in the AppleMap class:

https://github.com/10up/maps-block-apple/blob/develop/src/components/AppleMap.js#L108-L118

@jeffpaul jeffpaul moved this to To Do in Open Source Practice Oct 14, 2021
@jeffpaul jeffpaul moved this from To Do to Backlog in Open Source Practice Jun 28, 2022
@iamdharmesh iamdharmesh self-assigned this Nov 1, 2022
@iamdharmesh iamdharmesh mentioned this issue Nov 1, 2022
Merged
4 tasks
@iamdharmesh iamdharmesh moved this from Backlog to In Review in Open Source Practice Nov 1, 2022
Repository owner moved this from In Review to Merged in Open Source Practice Nov 18, 2022
@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.1.0 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamdharmesh iamdharmesh

Labels
help wanted Extra attention is needed
Projects
Open Source Practice
Archived in project
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Added support for custom marker icon. 10up/maps-block-apple
5 participants
@jeffpaul @dinhtungdu @iamdharmesh @fabiankaegy @vikrampm1