Disconnect Jobber account when plugin is deactivated#51
Merged
Conversation
faisal-alvi
approved these changes
May 22, 2025
Contributor
faisal-alvi
left a comment
There was a problem hiding this comment.
@dkotter Thanks for the work here! Tests well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
We currently have disconnect functionality in place that can be manually triggered from our settings page. But if someone connects their account and then deactivates the plugin, their site is technically still connected to Jobber.
This PR fixes that by adding a deactivation hook that will fire off the disconnect functionality.
Closes #50
How to test the Change
Because the disconnect functionality requires communication back and forth between the site and the middleware, this will only work if your site is publicly accessible (I tested locally using ngrok). If wanting to test the entire flow, follow the steps below:
Changelog Entry
Credits
Props @dkotter
Checklist: