Better API error handling in the editor#49
Merged
Conversation
…t continue to render the old form but only show the error state
faisal-alvi
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
While testing an issue with scopes, noticed if I switched from one form type that worked to a form type that didn't in the editor, we end up showing both an error state and the original form, whereas we should only show the error state. This PR fixes that by clearing out the iframe URL when an error happens.
How to test the Change
Not a great way to test. I found this because we changed scopes in our app and it broke the Booking form, while the Request form would still work. This has been addressed though so harder to reproduce this error state
Changelog Entry
Credits
Props @dkotter
Checklist: