Conversation
dkotter
requested changes
Apr 15, 2025
includes/classes/Blocks.php
Outdated
| '<p class="jobber-error">%s</p>', | ||
| esc_html( $response->get_error_message() ) | ||
| ); | ||
| // if we encounter an error when rendering on the front-end, |
Collaborator
There was a problem hiding this comment.
I think we need to add the same thing on line 81 below, if we end up in a situation where no iframe URL is returned
Contributor
Author
There was a problem hiding this comment.
Sure, I added the same comment with a little tweak. Please feel free to update it if needed.
b70f9d0
dkotter
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR returns nothing when an error is encountered on the front-end to avoid user confusion.
Closes #10
How to test the Change
Changelog Entry
Credits
Props @dkotter @faisal-alvi
Checklist: