Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP Acceptance and initial test #70

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Conversation

johnwatkins0
Copy link
Member

@johnwatkins0 johnwatkins0 commented Apr 20, 2020

Description of the Change

This resolves #45 by adding WP Acceptance along with an initial test. The test loads the editor for an existing post, clicks a paragraph, and inserts a special character into the paragraph.

I think this should also resolve #68 because the snapshot used in WP Acceptance has WP 5.4, and I used WP 5.4 locally while working through the test case.

This also adds WP Acceptance tests to the test.yml workflow already existing.

I think the PR will need to be merged before the tests actually run. Correction: No, it runs (and passes).

Alternate Designs

I wrote a single minimal test covering the most essential use case of the plugin. It's possible more tests could be added.

Benefits

Acceptance tests will run on all proposed changes to the plugin.

Possible Drawbacks

WP Acceptance can be slow.

Verification Process

This will need to be merged before it can be fully verified. After that, any issues with the test workflow can be resolved against the develop branch.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#45, #68

Changelog Entry

Added WP Acceptance tests

@johnwatkins0 johnwatkins0 self-assigned this Apr 20, 2020
@johnwatkins0 johnwatkins0 added the type:enhancement New feature or request. label Apr 20, 2020
@johnwatkins0 johnwatkins0 added this to the 1.1.0 milestone Apr 20, 2020
@johnwatkins0 johnwatkins0 requested a review from jeffpaul April 20, 2020 01:38
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnwatkins0 johnwatkins0 merged commit 305c169 into develop Apr 29, 2020
@johnwatkins0 johnwatkins0 deleted the feature/wp-acceptance branch April 29, 2020 14:54
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.3 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against WP 5.4 Add WP Acceptenace tests and Travis CI
2 participants