Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This resolves #45 by adding WP Acceptance along with an initial test. The test loads the editor for an existing post, clicks a paragraph, and inserts a special character into the paragraph.
I think this should also resolve #68 because the snapshot used in WP Acceptance has WP 5.4, and I used WP 5.4 locally while working through the test case.
This also adds WP Acceptance tests to the
test.yml
workflow already existing.I think the PR will need to be merged before the tests actually run. Correction: No, it runs (and passes).
Alternate Designs
I wrote a single minimal test covering the most essential use case of the plugin. It's possible more tests could be added.
Benefits
Acceptance tests will run on all proposed changes to the plugin.
Possible Drawbacks
WP Acceptance can be slow.
Verification Process
This will need to be merged before it can be fully verified. After that, any issues with the test workflow can be resolved against the develop branch.
Checklist:
Applicable Issues
#45, #68
Changelog Entry
Added WP Acceptance tests