Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus styles. #62

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add focus styles. #62

merged 1 commit into from
Feb 4, 2020

Conversation

samikeijonen
Copy link
Contributor

@samikeijonen samikeijonen commented Feb 3, 2020 •
edited
Loading

Description of the Change

Add focus style on buttons, they were missing from Firefox.

Benefits

Better accessibility for keyboard users.

Possible Drawbacks

None.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #27.

Changelog Entry

@jeffpaul jeffpaul added this to the 1.1.0 milestone Feb 3, 2020
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 3, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu February 3, 2020 22:28
dinhtungdu
dinhtungdu approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeffpaul jeffpaul merged commit 37f2488 into 10up:develop Feb 4, 2020
@samikeijonen samikeijonen deleted the tweak/focus-styles branch February 5, 2020 20:22
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.3 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@samikeijonen samikeijonen

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Check focus styles, also in Windows high contrast mode
3 participants
@samikeijonen @dinhtungdu @jeffpaul