Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for WP 6.2 #189

Merged
merged 7 commits into from
Jun 9, 2023
Merged

Fix tests for WP 6.2 #189

merged 7 commits into from
Jun 9, 2023

Conversation

ggutenberg
Copy link
Contributor

@ggutenberg ggutenberg commented Mar 21, 2023 •
edited
Loading

Description of the Change

Fixed E2E tests for WP 6.2. Specifically:

  • Upgrade Cypress to latest (12.8.1).
  • Add Cypress localStorage Commands at latest (2.2.2).
  • Use localStorage to bypass Block Welcome dialog.
  • Adjust target selectors for changes in WP 6.2.
  • Remove deprecated Cypress.Cookies.defaults().

Additionally, I tested the insertspecialcharacters-characters filter to make sure it was still working in WP 6.2.

How to test the Change

Create a file called .wp-env.override.json in the root of this folder with the following contents:

{
  "core": "WordPress/WordPress#6.2-branch"
}

Then run the following commands:

nvm install
npm ci
npm run build
npm run env start
npm run env clean all
npm run postenv:start
npm run cypress:run

Changelog Entry

Fixed - Failing E2E tests in WP 6.2

Credits

Props @ggutenberg

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@ggutenberg ggutenberg self-assigned this Mar 21, 2023
@ggutenberg ggutenberg requested a review from a team as a code owner March 21, 2023 16:58
@ggutenberg ggutenberg requested review from iamdharmesh and removed request for a team March 21, 2023 16:58
@jeffpaul jeffpaul added this to the 1.0.7 milestone Mar 21, 2023
iamdharmesh
iamdharmesh reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @ggutenberg, and apologies for the very delayed review. Just have 1 minor note on PR. Also, could you please help resolve conflicts?

Thanks

tests/cypress/e2e/insert-character-in-post.test.js Outdated
Comment on lines 4 to 15
cy.setLocalStorage(
`WP_DATA_USER_${ userId }`,
JSON.stringify({
'core/edit-post': {
preferences: {
features: {
welcomeGuide: false,
},
},
},
} )
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but maybe we can use cy.closeWelcomeGuide(); here?

@ggutenberg
Copy link
Contributor Author

ggutenberg commented May 5, 2023 •
edited
Loading

For some reason if I remove the .wp-env.override.json, this is throwing a very strange error now, which seems completely unrelated to the test. But I can't get past it.

Error: Error: FastAverageColor: Error loading image "https://pd.w.org/2023/04/654642d52f20d6367.57324872.jpg".
at Ql (:8889/wp-includes/js/dist/block-library.min.js?ver=3115f0b5551a55bb6d3b:14:2767)
at Image.l (:8889/wp-includes/js/dist/block-library.min.js?ver=3115f0b5551a55bb6d3b:14:5938)

It's happening randomly. I've seen it happen in the following two triggers:

cy.get(
	'.edit-post-header-toolbar__document-overview-toggle'
).click();

cy.get( '.charMap--category button[data-title="FOR ALL"]' ).click( {
	force: true,
} );

Any thoughts on where this is coming from?

@jeffpaul jeffpaul requested a review from iamdharmesh May 8, 2023 13:40
@iamdharmesh
Copy link
Member

For some reason if I remove the .wp-env.override.json, this is throwing a very strange error now, which seems completely unrelated to the test. But I can't get past it.

@ggutenberg This error is not related to the test, I have added code to ignore it, tests passing in WP minimum now. However, tests are still failing in WP6.2 and the error is similar to the issue reported here 10up/cypress-wp-utils#91. will check on this further once get some time to check on this.

Thanks

iamdharmesh
iamdharmesh approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Special thanks to @Sidsector9 for the fixing insertBlock issue.

@iamdharmesh iamdharmesh merged commit 127a053 into develop Jun 9, 2023
@iamdharmesh iamdharmesh deleted the fix/tests-wp-6.2 branch June 9, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@ggutenberg ggutenberg

Labels
None yet
Projects
Open Source Practice
Archived in project
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ggutenberg @iamdharmesh @jeffpaul