fix/165: make "most used" text translatable #172
Conversation
Sidsector9
requested review from
a team and
faisal-alvi
and removed request for
a team
There was a problem hiding this comment.
@Sidsector9 thanks for the PR. Code LGTM but when I changed the language to Italian (supported as per the org), it didn't change the "Most Used" text. That is probably because the text is not converted yet in the language files. Can you please share the steps to QA test this PR in any other way (if required, otherwise I'm ready to approve)?
The screenshot also shows the popup is cut out that seems to be fixed in #173 so ignoring here.
|
@faisal-alvi there's a fix in upstream that need to be merged. Once react-character-map 0.4.9 is released, we can connect to discuss this. |
|
@faisal-alvi I updated the react-character-map package to 0.4.9. You can follow the steps from here to test this - https://developer.wordpress.org/block-editor/how-to-guides/internationalization/ I tested this and it works for me:
|
Sidsector9
requested review from
iamdharmesh
and removed request for
faisal-alvi
There was a problem hiding this comment.
Thanks for the PR @Sidsector9, Code LGTM!
I tried to generate a pot file with wp-cli and it contains the "Most Used" string .I tried setup Loco translate with translated "Most Used" to something else and it seems working fine.
Note
Merge Dayjo/react-character-map#54 before merging this.
Description of the Change
Passed string to prop
mostUsedPaletteLabelTextto make text translatable.Steps to translate
Closes #165
Changelog Entry
Credits
Props @alexclassroom @Sidsector9