Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/114: add phpcs github action #129

Merged
merged 2 commits into from
Jun 7, 2022
Merged

upkeep/114: add phpcs github action #129

merged 2 commits into from
Jun 7, 2022

Conversation

Sidsector9
Copy link
Member

Description of the Change

Adds a Github Action for PHPCS linting.

Closes #114

Credits

Props @Sidsector9

@Sidsector9 Sidsector9 self-assigned this Jun 6, 2022
@Sidsector9 Sidsector9 added this to the 1.1.0 milestone Jun 6, 2022
@Sidsector9 Sidsector9 requested review from a team and cadic and removed request for a team June 6, 2022 06:55
@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2022

I think we're good to remove wpacceptance.json and anything else related to WP Acceptance.

cadic
cadic previously approved these changes Jun 7, 2022
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sidsector9, the code looks good!

@jeffpaul jeffpaul merged commit 727519b into develop Jun 7, 2022
@jeffpaul jeffpaul deleted the upkeep/114 branch June 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert testing action to linting action
3 participants