Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/30: Overflow added to content popover in mobile screens. #105

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

ajmaurya99
Copy link

@ajmaurya99 ajmaurya99 commented Oct 19, 2021

Description of the Change

On Mobile devices, the scroll bar in the popover wasn't able to reach all the characters. I have added an overflow CSS to allow the popover to add scrolling behaviour.

Designs

Desktop Behaviour - https://share.getcloudapp.com/6quv0BdP
Mobile Behaviour - https://share.getcloudapp.com/NQu7dDR9

Benefits

Now the whole list of the characters is accessible on the mobile devices.

Possible Drawbacks

Verification Process

Please try to add open the special characters popup on desktop as well as mobile devices and you should be able to access all the icons.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#30

Changelog Entry

Fix: Character map popover scrolling issue on mobile viewport

Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I've tested this locally in the mobile viewport, looks good.

@Sidsector9 Sidsector9 modified the milestones: 1.0.4, 1.1.0 Oct 19, 2021
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.4 Oct 19, 2021
@jeffpaul jeffpaul merged commit 780f0ae into develop Oct 19, 2021
@jeffpaul jeffpaul deleted the fix/30 branch October 19, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants