Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the CharacterMap in a Popover #1

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Conversation

adamsilverstein
Copy link

@adamsilverstein adamsilverstein commented Jul 9, 2019

Description of the Change

Wrap the CharacterMap in a Popover

Benefits

Displays the character picker in a popover.

Possible Drawbacks

Neets a little CSS attention, i tried to make the popover wider since we have so much to show, not sure that is the best targeting, mobile looks good already in my testing. Also popover could use a little padding or a border or something?

After CSS change:

Screencast

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

@adamsilverstein adamsilverstein force-pushed the feature/improvements-1 branch from 2005048 to f893d2f Compare July 9, 2019 22:38
@adamsilverstein adamsilverstein requested a review from helen July 9, 2019 22:39
@adamsilverstein adamsilverstein merged commit 0a59ff1 into master Jul 10, 2019
@jeffpaul jeffpaul added this to the 1.0.0 milestone Jul 18, 2019
@jeffpaul jeffpaul deleted the feature/improvements-1 branch February 8, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants