Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hide RichTextToolbarButton while editing #55

Closed
mahnunchik opened this issue Nov 20, 2019 · 9 comments · Fixed by #103
Closed

Do not hide RichTextToolbarButton while editing #55

mahnunchik opened this issue Nov 20, 2019 · 9 comments · Fixed by #103
Assignees
@pabamato
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone
1.0.4

Comments

@mahnunchik
Copy link

Do not hide RichTextToolbarButton while editing.

Describe the solution you'd like

Always return this code https://github.com/10up/insert-special-characters/blob/develop/src/insert-special-characters.js#L84
@mahnunchik mahnunchik added the type:enhancement New feature or request. label Nov 20, 2019
@jeffpaul
Copy link
Member

@mahnunchik are you asking that we have the Insert Special Characters item within the block toolbar and not within the dropdown (see #39)?

@jeffpaul jeffpaul added needs:feedback This requires reporter feedback to better understand the request. and removed type:enhancement New feature or request. labels Nov 21, 2019
@mahnunchik
Copy link
Author

Hi @jeffpaul No, I'm about blinking icon in the dropdown. RichTextToolbarButton should not be omitted from the output when isActive is true.

@jeffpaul
Copy link
Member

@mahnunchik apologies but I don't seem to understand your problem, could you please restate it so that I can try to understand it better? Also, if you have screenshots or a screencast that could help highlight the issue that would be helpful as well, thanks!

@jeffpaul
Copy link
Member

@mahnunchik any updates on further details on your issue so we can try to better troubleshoot for you?

@mahnunchik
Copy link
Author

Hi @jeffpaul please read the documentation of RichTextToolbarButton. It should be returned from the edit method regardless of conditions.

@jeffpaul jeffpaul added type:enhancement New feature or request. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jan 30, 2020
@jeffpaul jeffpaul added this to the 1.1.0 milestone Jan 30, 2020
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 30, 2020
@mahnunchik
Copy link
Author

Any news?

@jeffpaul
Copy link
Member

@mahnunchik none, but if you're able to work up a PR for this then we'd happily look to get that into an upcoming release.

@mahnunchik
Copy link
Author

Hi @jeffpaul do you understand the main idea of issue?

@mahnunchik mahnunchik mentioned this issue Apr 21, 2020
Closed
@johnwatkins0 johnwatkins0 removed their assignment Mar 14, 2021
@pabamato pabamato mentioned this issue Oct 5, 2021
Merged
6 tasks
@jeffpaul jeffpaul moved this to To Do in Open Source Practice Oct 14, 2021
@jeffpaul jeffpaul linked a pull request Nov 16, 2021 that will close this issue
Feature/issue 39 move settings to toolbar #103
Merged
6 tasks
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.4 Nov 16, 2021
@jeffpaul
Copy link
Member

Closed via #103.

Repository owner moved this from To Do to Merged in Open Source Practice Nov 16, 2021
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabamato pabamato

Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

Feature/issue 39 move settings to toolbar pabamato/insert-special-characters
4 participants
@mahnunchik @jeffpaul @pabamato @johnwatkins0