Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place Special Characters within block toolbar, not dropdown #39

Closed
1 of 2 tasks
jeffpaul opened this issue Sep 4, 2019 · 4 comments · Fixed by #103
Closed
1 of 2 tasks

Place Special Characters within block toolbar, not dropdown #39

jeffpaul opened this issue Sep 4, 2019 · 4 comments · Fixed by #103
Assignees
@pabamato @Sidsector9
Labels
type:enhancement New feature or request.
Milestone
1.0.4

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Sep 4, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.
Some feedback from the .org forums on this topic: 1, 2, and 3. Related details on how to possibly handle this within Gutenberg are noted in WordPress/gutenberg#14881.

Describe the solution you'd like

  • move Special Characters from dropdown menu to a main block menu button
  • possibly add a setting within Gutenberg to allow users to set whether the option is in the dropdown or main block menu?

Designs
n/a

Describe alternatives you've considered
keep as-is

Additional context
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Sep 4, 2019
@jeffpaul jeffpaul added this to the Future Release milestone Sep 4, 2019
@jeffpaul jeffpaul mentioned this issue Nov 21, 2019
Closed
@jeffpaul
Copy link
Member Author

jeffpaul commented Sep 23, 2021 •
edited
Loading

Related details on this: https://twitter.com/leeshadle/status/1436032704995217409?s=12. Would probably consider this as the 4th example in the image within the tweet:
<BlockControls group="inline" />

@pabamato pabamato self-assigned this Oct 4, 2021
@pabamato pabamato mentioned this issue Oct 5, 2021
Merged
6 tasks
@pabamato pabamato linked a pull request Oct 5, 2021 that will close this issue
Feature/issue 39 move settings to toolbar #103
Merged
6 tasks
@jeffpaul jeffpaul modified the milestones: Future Release, 1.1.0 Oct 5, 2021
@jeffpaul
Copy link
Member Author

jeffpaul commented Oct 5, 2021

Note that the linked PR handles the first part of this issue, we can hold off on the 2nd part for a separate PR / future release.

@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.4 Oct 8, 2021
@jeffpaul jeffpaul moved this from To Do to In Review in Open Source Practice Oct 22, 2021
@jeffpaul jeffpaul moved this to To Do in Open Source Practice Oct 22, 2021
@Sidsector9
Copy link
Member

@jeffpaul should this setting be local to a post/page or should it be a global setting saved in options?

Repository owner moved this from In Review to Merged in Open Source Practice Nov 2, 2021
@jeffpaul
Copy link
Member Author

jeffpaul commented Nov 2, 2021

@Sidsector9 I think we can hold off on the second checklist item here and see how the community reacts to getting this into the main block menu which has been the primary request for some time. If folks ask for ability to set where the special characters button "lives" then we can re-investigate in the future.

@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabamato pabamato

@Sidsector9 Sidsector9

Labels
type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

Feature/issue 39 move settings to toolbar pabamato/insert-special-characters
3 participants
@jeffpaul @pabamato @Sidsector9