Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Insert Characters Shortcut #36

Closed
mrwweb opened this issue Sep 2, 2019 · 2 comments · Fixed by #44
Closed

Document Insert Characters Shortcut #36

mrwweb opened this issue Sep 2, 2019 · 2 comments · Fixed by #44
Assignees
Labels
help wanted Extra attention is needed needs:documentation This requires documentation. type:good-first-issue Good for newcomers.
Milestone

Comments

@mrwweb
Copy link

mrwweb commented Sep 2, 2019

The only reason I know about the ctrl/cmd + o shortcut is that @helen mentioned in a Github comment. That should be added to the readme and plugin description for sure!

@mrwweb mrwweb added the type:enhancement New feature or request. label Sep 2, 2019
@jeffpaul jeffpaul added needs:documentation This requires documentation. and removed type:enhancement New feature or request. labels Sep 3, 2019
@jeffpaul jeffpaul added this to the 1.1.0 milestone Sep 3, 2019
@jeffpaul
Copy link
Member

jeffpaul commented Sep 3, 2019

@mrwweb good call! If you're able to submit a PR with those changes I'd gladly ensure that gets through review and into our next release. Otherwise I'll look to cover that after I get through updating the character sets in #24.

@jeffpaul jeffpaul added type:good-first-issue Good for newcomers. help wanted Extra attention is needed labels Sep 3, 2019
@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.1 Sep 6, 2019
@jeffpaul jeffpaul self-assigned this Sep 6, 2019
@jeffpaul
Copy link
Member

jeffpaul commented Sep 6, 2019

@mrwweb thanks again for noting this docs change! We've merged the PR and this should get updated shortly with our pending v1.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:documentation This requires documentation. type:good-first-issue Good for newcomers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants