Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent scrollbar in Popover, can't reach all characters #30

Closed
adamsilverstein opened this issue Aug 28, 2019 · 5 comments
Closed
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@adamsilverstein
Copy link

Likely an upstream bug, tracking work on this here.

@adamsilverstein adamsilverstein added the type:bug Something isn't working. label Aug 28, 2019
@adamsilverstein adamsilverstein self-assigned this Aug 28, 2019
@jeffpaul jeffpaul added this to the 1.0.0 milestone Aug 28, 2019
@jeffpaul
Copy link
Member

Also seems similar to #25.

@helen
Copy link
Contributor

helen commented Aug 28, 2019

I think we can use this to track the broader issue and close #25 with #31.

In digging into this and trying to understand the math in https://github.com/WordPress/gutenberg/blob/master/packages/components/src/popover/utils.js#L79-L162, it seems that the inner content height at the time of the popover initially being calculated on first open and on repositioning is 30px, my suspicion is that it's not fully rendered yet, but I haven't dug into this much more yet.

@ajmaurya99
Copy link

Hey @jeffpaul @helen I noticed that the scroll bar was not working on the mobile devices, due to which all the icons were not accessible. So I added a scroll behaviour to the popover.
PR - #105

Demo
Desktop Behaviour - https://share.getcloudapp.com/6quv0BdP
Mobile Behaviour - https://share.getcloudapp.com/NQu7dDR9

@jeffpaul jeffpaul modified the milestones: 1.1.0, 1.0.4 Oct 19, 2021
@jeffpaul jeffpaul moved this from To Do to Merged in Open Source Practice Oct 19, 2021
@jeffpaul
Copy link
Member

jeffpaul commented Nov 8, 2021

Closed via #105.

@jeffpaul jeffpaul closed this as completed Nov 8, 2021
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

4 participants