Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial UX Revamp #231

Closed
fabiankaegy opened this issue Dec 7, 2023 · 1 comment · Fixed by #263
Closed

Editorial UX Revamp #231

fabiankaegy opened this issue Dec 7, 2023 · 1 comment · Fixed by #263
Assignees
@psorensen
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone
1.1.3

Comments

@fabiankaegy
Copy link
Member

fabiankaegy commented Dec 7, 2023 •
edited
Loading

Overall Feedback

The Popover modal containing all the special characters doesn't feel native to the editor. The spacing, form styling and general arrangement of the elements is off compared to the rest of the editor UI.

CleanShot 2023-12-07 at 10 00 55@2x

In order to improve this, I would suggest we look at for example the Icon Picker we built as part of the 10up block components and get inspired by it's popover: https://github.com/10up/block-components/tree/develop/components/icon-picker

I would still make the modal wider because the character density is larger here but we should leverage WordPress components like the SearchControl and Tabs

Other Nitpicks:

  1. On Mac Safari I cannot use the CMD + O shortcut because the browser already uses it 🤔
  2. The Toolbar Icon has some odd spacing on either side that should not be there. I think this is coming from how the toolbar item is added.
    CleanShot 2023-12-07 at 09 58 49@2x
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Dec 7, 2023
@jeffpaul jeffpaul added this to the Future Release milestone Dec 7, 2023
@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted Extra attention is needed labels Dec 7, 2023
@pabamato pabamato self-assigned this Mar 26, 2024
@psorensen psorensen self-assigned this Jul 17, 2024
@psorensen psorensen mentioned this issue Jul 22, 2024
Merged
4 tasks
@psorensen
Copy link
Contributor

@fabiankaegy #263 is an iterative attempt to get us closer to a more consistent UI, but doesn't fully reach the goal. Unfortunately due to lack of customization of the library used to insert the characters, I don't think this will be possible without a bunch of CSS. Personally, I think a rebuild would be the ultimate solution - I don't think the library dependency is doing so much that we couldn't easily replicate ourselves using all WP UI components.

@psorensen psorensen moved this from To Do to Code Review in Open Source Practice Jul 23, 2024
@psorensen psorensen moved this from Code Review to In Progress in Open Source Practice Jul 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Practice Aug 5, 2024
@jeffpaul jeffpaul modified the milestones: Future Release, 1.2.0 Aug 5, 2024
@dkotter dkotter modified the milestones: 1.2.0, 1.1.3 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psorensen psorensen

Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.1.3
Development

Successfully merging a pull request may close this issue.

make UI more consistent with core WP 10up/insert-special-characters
5 participants
@dkotter @jeffpaul @pabamato @psorensen @fabiankaegy