Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UI string "Most used" internationalizable #165

Closed
1 task done
alexclassroom opened this issue Oct 15, 2022 · 2 comments · Fixed by #172
Closed
1 task done

Make UI string "Most used" internationalizable #165

alexclassroom opened this issue Oct 15, 2022 · 2 comments · Fixed by #172
Assignees
@Sidsector9
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone
1.0.6

Comments

@alexclassroom
Copy link

Is your enhancement related to a problem? Please describe.

I fully localized this plugin to zh_TW, and I found the UI string "Most used" is not internationalized.

Designs

Insert-Special-Chracters-Most-Used

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexclassroom alexclassroom added the type:enhancement New feature or request. label Oct 15, 2022
@vikrampm1 vikrampm1 moved this to Incoming in Open Source Practice Oct 17, 2022
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Oct 17, 2022
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Oct 17, 2022
@jeffpaul jeffpaul added this to the Future Release milestone Oct 17, 2022
@jeffpaul
Copy link
Member

@alexclassroom thanks for calling that out! If you'd like to work on a PR to fix that, then I'd gladly get it through code review and into a future release... thanks!

@alexclassroom
Copy link
Author

Making UI strings internationalizable in JS files is too difficult for me, sorry about this.

@Sidsector9 Sidsector9 self-assigned this Nov 21, 2022
@Sidsector9 Sidsector9 mentioned this issue Nov 21, 2022
Merged
@jeffpaul jeffpaul modified the milestones: Future Release, 1.0.6 Nov 30, 2022
@jeffpaul jeffpaul moved this from Backlog to In Review in Open Source Practice Dec 1, 2022
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
1.0.6
Development

Successfully merging a pull request may close this issue.

fix/165: make "most used" text translatable 10up/insert-special-characters
3 participants
@jeffpaul @alexclassroom @Sidsector9