upkeep/78: bump min WP and PHP versions #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
iamdharmesh
and removed request for
a team
iamdharmesh
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks for the PR @Sidsector9, PR changes looks good to me. However, 1-2 minor changes are required before getting this merged.
- Update versions in technical notes of readme.txt - https://github.com/10up/insecure-content-warning/blob/develop/readme.txt#L21-L22
- Node version in package.json - https://github.com/10up/insecure-content-warning/blob/develop/package.json#L82
Thanks
|
@iamdharmesh as discussed on call, let's keep the node version on 12 as the dependencies are very old. |
iamdharmesh
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Thanks for the changes @jeffpaul @Sidsector9. LGTM 🚀
@Sidsector9 I rollbacked node version to v12 as discussed
|
Linting issues appear to be preexisting so going to merge this in and we can sort out the linting concerns separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #78
Changelog Entry
Credits
Props @vikrampm1 @Sidsector9
Checklist: