Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Cypress for end-to-end tests #75

Merged
merged 26 commits into from
Jan 9, 2023
Merged

Setup Cypress for end-to-end tests #75

merged 26 commits into from
Jan 9, 2023

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 27, 2022 •
edited
Loading

Description of the Change

Added tests for:

  • Block Editor
  • Classic Editor

Closes #71

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@cadic cadic added this to the 1.1.0 milestone May 27, 2022
@cadic cadic self-assigned this May 27, 2022
@dkotter dkotter modified the milestones: 1.0.2, Future Release Jun 27, 2022
@jeffpaul
Copy link
Member

@cadic want to open this up for review perhaps and then open a subsequent issue to document additional work to be done for e2e tests to keep this moving along?

@jeffpaul jeffpaul modified the milestones: Future Release, 1.0.3 Jun 28, 2022
@jeffpaul
Copy link
Member

@cadic anything else needed in this PR before it can be moved out of draft for review/merge?

@cadic
Copy link
Contributor Author

cadic commented Nov 16, 2022

@jeffpaul this was staying on hold too long, waiting for classic editor functions to be added into our https://github.com/10up/cypress-wp-utils and now this PR is ready to proceed. It also needs some updates (upgrade Cypress from 9 to 10 or probably 11)

@cadic cadic marked this pull request as ready for review December 16, 2022 12:37
@cadic cadic requested review from a team and iamdharmesh and removed request for a team December 18, 2022 15:41
iamdharmesh
iamdharmesh reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on adding E2E tests. The code looks good to me. just added 2 minor nice-to-have comments. Please let me know what you think about that.

Thanks

@dkotter dkotter modified the milestones: 1.0.3, 1.1.0 Jan 6, 2023
@cadic cadic requested a review from iamdharmesh January 6, 2023 19:08
iamdharmesh
iamdharmesh approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes @cadic, LGTM now 🚀

@jeffpaul
Copy link
Member

jeffpaul commented Jan 9, 2023

@dkotter will leave up to you if you want to merge in ahead of the 1.0.3 release here

@dkotter dkotter modified the milestones: 1.1.0, 1.0.3 Jan 9, 2023
@dkotter dkotter merged commit 568e88a into develop Jan 9, 2023
@dkotter dkotter deleted the tests/cypress branch January 9, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Setup Cypress for E2E testing
4 participants
@cadic @jeffpaul @iamdharmesh @dkotter