Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run our E2E tests on our generated release zip #182

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Aug 20, 2024

Description of the Change

This PR updates our E2E workflow to run tests on the zip that is generated by our Build Release Zip Action. This allows us to run those tests on the same code that will be released to production.

In addition, we were using outdated versions of quite a few Actions so this PR updates those all to their latest versions.

Closes #146 and #181

How to test the Change

Verify all workflows run correctly on this PR

Changelog Entry

Changed - Run E2E tests on the zip generated by "Build release zip" action.

Credits

Props @dkotter, @iamdharmesh

Checklist:

… cypress action to use the zip from the build zip action. Update all the actions we use in those workflows
@dkotter dkotter added this to the 1.3.0 milestone Aug 20, 2024
@dkotter dkotter self-assigned this Aug 20, 2024
@dkotter dkotter requested a review from jeffpaul as a code owner August 20, 2024 20:04
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 20, 2024
@dkotter dkotter requested review from iamdharmesh and removed request for jeffpaul August 20, 2024 20:43
@dkotter dkotter modified the milestones: 1.3.0, 1.2.1 Aug 20, 2024
@dkotter dkotter linked an issue Aug 20, 2024 that may be closed by this pull request
1 task
iamdharmesh
iamdharmesh previously approved these changes Aug 21, 2024
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dkotter. LGTM.

Note: I made a minor change to the wp-env config to use the plugin from the zip file.

@dkotter dkotter merged commit 83652c5 into develop Aug 21, 2024
6 of 7 checks passed
@dkotter dkotter deleted the feature/release-e2e branch August 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E test failure Run E2E tests on the zip generated by "Build release zip" action.
2 participants