-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump WordPress "tested up to" version 6.6 #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to bump our minimum WordPress version in our E2E tests as well. Those are failing right now because it's using WordPress 6.3 and the plugin can't be installed there anymore: https://github.com/10up/insecure-content-warning/blob/develop/.github/workflows/cypress.yml#L47
Still seeing e2e test failures, guessing that's another wp-env / dependency update that's needed? |
Hello @dkotter I updated WP Min version and wp-env version but tests are still failing here. COuld you check or suggest changes here? thank you! |
This seems to be the same issue Dharmesh mentions here: #172 (review). So this looks good to me |
Description of the Change
This PR bumps the WP tested up to version 6.6, and bumps the WP min to 6.4.
Closes #174
How to test the Change
Changelog Entry
Credits
Props @ankitguptaindia
Checklist: