Skip to content

Bump WordPress "tested up to" version 6.6 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkotter merged 5 commits into from
Jul 11, 2024
Merged

Bump WordPress "tested up to" version 6.6 #176

dkotter merged 5 commits into from
Jul 11, 2024

Conversation

@ankitguptaindia
Copy link
Member

@ankitguptaindia ankitguptaindia commented Jul 8, 2024

Description of the Change

This PR bumps the WP tested up to version 6.6, and bumps the WP min to 6.4.

Closes #174

How to test the Change

Changelog Entry

Changed - Bump WordPress "tested up to" version 6.6.
Changed - Bump WordPress minimum from 6.3 to 6.4.

Credits

Props @ankitguptaindia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@ankitguptaindia ankitguptaindia self-assigned this Jul 8, 2024
@github-actions github-actions bot added this to the 1.3.0 milestone Jul 8, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 8, 2024
dkotter
dkotter requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to bump our minimum WordPress version in our E2E tests as well. Those are failing right now because it's using WordPress 6.3 and the plugin can't be installed there anymore: https://github.com/10up/insecure-content-warning/blob/develop/.github/workflows/cypress.yml#L47

@jeffpaul
Copy link
Member

jeffpaul commented Jul 9, 2024

Still seeing e2e test failures, guessing that's another wp-env / dependency update that's needed?

@ankitguptaindia
Copy link
Member Author

ankitguptaindia commented Jul 10, 2024 •
edited
Loading

Hello @dkotter I updated WP Min version and wp-env version but tests are still failing here. COuld you check or suggest changes here? thank you!

@dkotter
Copy link
Collaborator

dkotter commented Jul 11, 2024

Hello @dkotter I updated WP Min version and wp-env version but tests are still failing here. COuld you check or suggest changes here? thank you!

This seems to be the same issue Dharmesh mentions here: #172 (review). So this looks good to me

@dkotter dkotter merged commit 079c84a into develop Jul 11, 2024
@dkotter dkotter deleted the wp-compat-v6.6 branch July 11, 2024 13:31
@dkotter dkotter modified the milestones: 1.3.0, 1.2.1 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@ankitguptaindia ankitguptaindia

Labels

needs:code-review This requires code review.

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with an upcoming version of WordPress

3 participants

@ankitguptaindia @jeffpaul @dkotter