Properly handle fixing of multiple different instances of insecure content #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
approved these changes
Aug 23, 2023
Member
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
Thank you for fixing this @kmgalanakis. LGTM!
jeffpaul
deleted the
fix/only-the-first-instance-of-insecure-content-is-fixed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In this MR I'm properly handling the fixing and highlighting of multiple different instances of insecure content in the same post.
Closes #138
How to test the Change
See the reproduction steps at #138
Changelog Entry
Credits
Props @kmgalanakis
Checklist: