Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check parent elements in the block editor #108

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Check parent elements in the block editor #108

merged 3 commits into from
Apr 3, 2023

Conversation

nateconley
Copy link
Contributor

Description of the Change

When using the block editor, the checks expect elements with insecure content to be wrapped in another element. In the cases of HTML blocks and converted Class Editor blocks, this is not always true.

Closes #72

How to test the Change

  • Follow the steps in the video in Doesn't see insecure elements inside Classic Block #72 to test a converted classic editor insecure image
  • Place an HTML block with insecure content: <img src="http://google.com/dummy1.jpg" />

Changelog Entry

Fixed - Ensure that HTML blocks and converted classic editor blocks are correctly checked for insecure content.

Credits

@nateconley

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@nateconley nateconley requested a review from a team as a code owner January 30, 2023 20:56
@nateconley nateconley requested review from Sidsector9 and removed request for a team January 30, 2023 20:56
@nateconley nateconley self-assigned this Jan 30, 2023
@jeffpaul jeffpaul added this to the 1.1.0 milestone Mar 1, 2023
Sidsector9
Sidsector9 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM and tested well 👍

Ignoring the eslint issue for now as it is tightly coupled with node/NPM versions and few other dependencies.

Opened issues #114 and #115.

@jeffpaul I think we can merge this as it is not blocking.

@jeffpaul jeffpaul merged commit 56cce89 into develop Apr 3, 2023
@jeffpaul jeffpaul deleted the fix/72 branch April 3, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@nateconley nateconley

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Doesn't see insecure elements inside Classic Block
3 participants
@nateconley @Sidsector9 @jeffpaul