Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test failure #181

Closed
1 task done
faisal-alvi opened this issue Aug 14, 2024 · 0 comments · Fixed by #182
Closed
1 task done

E2E test failure #181

faisal-alvi opened this issue Aug 14, 2024 · 0 comments · Fixed by #182
Assignees
@dkotter
Labels
type:bug Something isn't working.
Milestone
1.2.1

Comments

@faisal-alvi
Copy link
Member

Describe the bug

While reviewing PR #179, I noticed an E2E failure that has been occurring in the develop branch for a while.

The issue is an AssertionError where an element is expected to be found once but is instead found three times.

This should be fixed.

Steps to Reproduce

https://github.com/10up/insecure-content-warning/actions/runs/10379979246/job/28739124087?pr=179

Screenshots, screen recording, code snippet

image

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@faisal-alvi faisal-alvi added the type:bug Something isn't working. label Aug 14, 2024
@faisal-alvi faisal-alvi mentioned this issue Aug 14, 2024
Merged
@jeffpaul jeffpaul added this to the 1.3.0 milestone Aug 14, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Aug 14, 2024
@dkotter dkotter modified the milestones: 1.3.0, 1.2.1 Aug 20, 2024
@dkotter dkotter mentioned this issue Aug 20, 2024
Merged
4 tasks
@dkotter dkotter linked a pull request Aug 20, 2024 that will close this issue
Run our E2E tests on our generated release zip #182
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from To Do to Done in Open Source Practice Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkotter dkotter

Labels
type:bug Something isn't working.
Projects
Open Source Practice
Archived in project
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Run our E2E tests on our generated release zip 10up/insecure-content-warning
3 participants
@dkotter @jeffpaul @faisal-alvi